Allow files to be wrapped with a mutator during add #5184
Conversation
ghost
assigned 
whyrusleeping
changed the title
| Wrap bool | ||
| NoCopy bool | ||
| Chunker string | ||
| FileWrapper func(io.Reader) (io.Reader, error) |
There was a problem hiding this comment.
Why are all the field listed as modified? The FileWrapper is the only new field right? Also, just to be extra annoying, could we add a comment explaining the function of the newly added field? I'm a strong believer in the broken windows theory :)
There was a problem hiding this comment.
That's gofmt. It aligns everything.
| @@ -114,6 +115,14 @@ func (adder *Adder) SetMfsRoot(r *mfs.Root) { | |||
|
|
|||
| // Constructs a node from reader's data, and adds it. Doesn't pin. | |||
| func (adder *Adder) add(reader io.Reader) (ipld.Node, error) { | |||
| if adder.FileWrapper != nil { | |||
| wr, err := adder.FileWrapper(reader) | |||
There was a problem hiding this comment.
So, this is the single point of entry of a reader to the chunker right? (The other similar calls I'm finding in the code are for testing purposes only.)
|
After the files refactor (#5661) lands, it should be fairly easy to just wrap file interfaces to do this without having to modify the adder (and it will work via coreapi without touching internals) |
|
Closing in favor of a |
I'm playing around with different ways of importing files in a side project, and this small change allows me to encrypt or compress files on the fly.
License: MIT
Signed-off-by: Whyrusleeping why@ipfs.com