Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unixfs: fix FSNode accessor in NewDirectoryFromNode #5239

Merged
merged 1 commit into from
Jul 16, 2018
Merged

unixfs: fix FSNode accessor in NewDirectoryFromNode #5239

merged 1 commit into from
Jul 16, 2018

Conversation

schomatis
Copy link
Contributor

Recently merged PR #5189 conflicted with #5160.

@schomatis
unixfs: fix FSNode accessor in NewDirectoryFromNode
26feaeb 
License: MIT
Signed-off-by: Lucas Molas <schomatis@gmail.com>
@schomatis schomatis added kind/bug A bug in existing code (including security flaws) topic/build Topic build labels Jul 16, 2018
@schomatis schomatis self-assigned this Jul 16, 2018
@schomatis schomatis requested a review from whyrusleeping July 16, 2018 15:31
@schomatis schomatis requested a review from Kubuxu as a code owner July 16, 2018 15:31
@ghost ghost added the status/in-progress In progress label Jul 16, 2018
@schomatis schomatis mentioned this pull request Jul 16, 2018
Merged
@schomatis
Copy link
Contributor Author

One PR was renaming the GetType() accessor that the other one was using, but GitHub didn't complain, because the file was being renamed? I would like to understand what went wrong here to avoid making the same mistake in the future

@whyrusleeping
Copy link
Member

@schomatis I think its because github doesnt rerun CI on merge, which it kinda probably should. Not a big deal, we caught it quick

@whyrusleeping whyrusleeping merged commit 0349d9d into ipfs:master Jul 16, 2018
@ghost ghost removed the status/in-progress In progress label Jul 16, 2018
@schomatis schomatis deleted the fix/unixfs/directory/type-accessor branch July 16, 2018 15:52
@Stebalien Stebalien mentioned this pull request Jul 16, 2018
Closed
This was referenced Jul 16, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@schomatis schomatis

Labels
kind/bug A bug in existing code (including security flaws) topic/build Topic build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schomatis @whyrusleeping