Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build tag to disable dynamic plugins #5274

Merged
merged 1 commit into from
Jul 23, 2018
Merged

build tag to disable dynamic plugins #5274

merged 1 commit into from
Jul 23, 2018

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Jul 22, 2018

Currently it's not possible to debug applications which use the "plugin" package (golang/go#23733)

@magik6k
build tag to disable dynamic plugins
c858244 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k magik6k requested a review from Kubuxu as a code owner July 22, 2018 19:25
@ghost ghost assigned magik6k Jul 22, 2018
@ghost ghost added the status/in-progress In progress label Jul 22, 2018
@whyrusleeping
Copy link
Member

LGTM, thanks @magik6k

@whyrusleeping whyrusleeping merged commit 8a29985 into master Jul 23, 2018
@ghost ghost removed the status/in-progress In progress label Jul 23, 2018
@whyrusleeping whyrusleeping deleted the feat/noplugin branch July 23, 2018 01:35
@schomatis
Copy link
Contributor

YEAH!! Finally we can use Delve again to debug go-ipfs, with the bump to go1.10 the debug_frame had been lost, thanks @magik6k :)

@schomatis
Copy link
Contributor

This now works:

dlv debug github.com/ipfs/go-ipfs/cmd/ipfs --build-flags "-tags noplugin" -- add . -r

😃

@schomatis schomatis mentioned this pull request Dec 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@magik6k magik6k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magik6k @whyrusleeping @schomatis