Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] gx: update go-merkledag to match version used in go-unixfs #5330

Closed
wants to merge 1 commit into from
Closed

[WIP] gx: update go-merkledag to match version used in go-unixfs #5330

wants to merge 1 commit into from

Conversation

schomatis
Copy link
Contributor

@schomatis schomatis commented Aug 2, 2018

Do not merge.

See ipfs/go-unixfs#4.

@schomatis schomatis requested a review from Kubuxu as a code owner August 2, 2018 03:37
@ghost ghost assigned schomatis Aug 2, 2018
@ghost ghost added the status/in-progress In progress label Aug 2, 2018
@schomatis schomatis closed this Aug 2, 2018
@ghost ghost removed the status/in-progress In progress label Aug 2, 2018
License: MIT
Signed-off-by: Lucas Molas <schomatis@gmail.com>
@schomatis
Copy link
Contributor Author

Closed due to forced push.

@schomatis schomatis reopened this Aug 2, 2018
@ghost ghost added the status/in-progress In progress label Aug 2, 2018
@whyrusleeping
Copy link
Member

You'll also need to update go-blockservice I think. Run gx deps dupes to see if anything looks wrong.

@schomatis
Copy link
Contributor Author

gx deps dupes reported (among many duplicates) the old hash of go-merkledag being used, I grep'ed for it in the gx dir (is there an easier way for this? a gx flag to know which package is importing the old hash?) and it seems that the go-path version used in go-ipfs is using it, although this doesn't affect the build (probably because those two don't interact), should I update the go-path version in this same PR?

@schomatis
Copy link
Contributor Author

So, this is breaking the build because I updated go-merkledag to the version used by the master branch of go-unixfs (for gx-go link to work) but go-ipfs is using a gx-version of go-unixfs which is actually using the old go-merkledag version (QmRy4Q...s59) that I'm updating here, so I guess I need to first update go-unixfs here to the master version gx-release (that uses the new go-merkledag version QmfGzd...9TS) and then update go-merkledag, or maybe that needs to happen in the same PR otherwise I think there might be a version mismatch in the converse relation of the what's happening here now that's breaking the build (my head is aching at this point so I'm going to take a pause here and rethink this, let's not merge anything until then).

@schomatis schomatis changed the title gx: update go-merkledag to match version used in go-unixfs [WIP] gx: update go-merkledag to match version used in go-unixfs Aug 2, 2018
@schomatis
Copy link
Contributor Author

Closing in favor of #5336, thanks @hsanjuan!

@schomatis schomatis closed this Aug 3, 2018
@ghost ghost removed the status/in-progress In progress label Aug 3, 2018
@schomatis schomatis deleted the gx-update/go-merkledag branch August 3, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants