coreapi: dag: Batching interface #5340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
ghost
assigned
magik6k
commented
Aug 3, 2018
| DagOps | ||
|
|
||
| // Commit commits nodes to the datastore and announces them to the network | ||
| Commit(ctx context.Context) error |
There was a problem hiding this comment.
Note: need this context for go-ipfs-api implementation (batch will hold a connection and stream files to dag/put)
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
magik6k
force-pushed
the
feat/coreapi/dagbatch
branch
from
70be734
to
d6ee955
Compare
| // DagAPI specifies the interface to IPLD | ||
| type DagAPI interface { | ||
| // DagOps groups operations that can be batched together | ||
| type DagOps interface { |
There was a problem hiding this comment.
We will probably also have Delete on this interface, right?
There was a problem hiding this comment.
Well, there isn't dag rm so I didn't add it here. But yes, that would be the place for that (will be in Block API, but that's for a separate PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the nicest way to get batching in coreapi, but if you have some better ideas, I'm happy to hear them
Part of #5215 / #4498