early out if no entries in wantlist #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wanna put the guard before the logging setup? (NB: if guard is before then, the guard's message is printed and that should be sufficient) |
|
Yeah, good point. |
whyrusleeping
force-pushed
the
bitswap/tweak
branch
from
1c7b427
to
a09854d
Compare
|
LGTM |
btc
pushed a commit
that referenced
this pull request
Jan 11, 2015
early out if no entries in wantlist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept seeing a lot of extra work being done for no reason. This just provides an early out for the bitswap clientWorkers rebroadcast.