Gateway Server #541
Merged
Gateway Server #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds trailing slash redirection index.html return templated directory listing Signed off : Simon Kirkby <tigger@interthingy.com>
replaced H moved internal errors into function. Signed-off-by: Simon Kirkby <tigger@interthingy.com>
|
👍 |
|
The description of this PR makes me very happy. |
| // if there is an error (invalid address), then don't run the gateway | ||
| gatewayMaddr, _ := ma.NewMultiaddr(cfg.Addresses.Gateway) | ||
| if gatewayMaddr == nil { | ||
| fmt.Println("Invalid gateway address, not running gateway") |
There was a problem hiding this comment.
might want to just not display anything to the user, since it's normal operation. maybe just log.Info? and 👍 on the comment re: error
|
I fixed up this PR. Merging after green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a second HTTP server that serves IPFS objects, without giving access to the command API (so that it can be used for public services, like ipfs.io). It is off by default, but will listen when there is an address specified at the
Addresses.Gatewaykey in the config.This also fixes MIME type handling in the gateway so that web apps will be function correctly when served from the gateway or API server.
@zignig's directory listing changes were included.
A redirect was added from
/webuion the API server to the hash of the webui app root. In the future, we can change the hash to an IPNS path, and update the webui by publishing to that IPNS name.