testutil ci pkgs check env vars #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good thing, i checked one wrong, too!
|
https://build.protocol-dev.com/job/ipfs_test_all_commits_on_branch/50/console failed on a timing test, on the commit before the disabling, so it's fine. |
|
👏 |
|
@briantigerchow i'm going to merge despite races-- it will help make sure our tests aren't bogus. |
jbenet
added a commit
that referenced
this pull request
Jan 15, 2015
testutil ci pkgs check env vars
SGTM was just about to myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we checked the env vars all over the place.
This PR moves all that into own packages. And adds
some nice env vars, should they become relevant to
other, tougher tests, or orchestration tools. And,
it caught a bug! We weren't checking it right...
@briantigerchow will like this PR.