Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core) replace config.Config with repo.Repo #578

Merged
merged 16 commits into from
Jan 18, 2015
Merged

feat(core) replace config.Config with repo.Repo #578

merged 16 commits into from
Jan 18, 2015

Conversation

btc
Copy link
Contributor

@btc btc commented Jan 15, 2015

closes #376 RFCR @jbenet

@btc btc added the status/in-progress In progress label Jan 15, 2015
@btc btc mentioned this pull request Jan 15, 2015
Closed
3 tasks
@jbenet jbenet modified the milestone: α Jan 15, 2015
@btc btc force-pushed the feat/core+repo branch 4 times, most recently from 2a9559d to df4d122 Compare January 16, 2015 02:15
@jbenet
Copy link
Member

jbenet commented Jan 16, 2015

LGTM but see failing tests

@btc
Copy link
Contributor Author

btc commented Jan 16, 2015

failing test is

ok github.com/jbenet/go-ipfs/util 0.228s
--- FAIL: TestDeadlineFractionHalf (0.01 seconds)
fracctx_test.go:75: ctx1 ended too early

Should we activate if jenkins.Skip() for this one?

@jbenet
Copy link
Member

jbenet commented Jan 16, 2015

TestDeadlineFractionHalf -- if jenkins.Skip()

Yeah, sure. sigh timing.

@briantigerchow and https://build.protocol-dev.com/job/network-test/930/console

@btc btc force-pushed the feat/core+repo branch 2 times, most recently from 624a3f3 to 68c9986 Compare January 16, 2015 09:08
@btc
Copy link
Contributor Author

btc commented Jan 16, 2015

@briantigerchow and https://build.protocol-dev.com/job/network-test/930/console

Ah thanks. Missed that. Thank goodness for online tests.

@btc
Copy link
Contributor Author

btc commented Jan 16, 2015

All tests pass, but I'd like to read through one more time before merging. Mind if I merge this tomorrow?

@jbenet
Copy link
Member

jbenet commented Jan 16, 2015

@briantigerchow 👍 no rush

@btc btc force-pushed the feat/core+repo branch 5 times, most recently from d0f15c7 to c457a84 Compare January 18, 2015 22:29
Brian Tiger Chow added 8 commits January 18, 2015 14:41
Brian Tiger Chow added 8 commits January 18, 2015 14:41
refactor(core) Close in teardown
1edc5c0 
This declarative style is simpler to compose than the imperative wiring
up of objects.

+ pass context to StartOnlineServices as parameter. one by one, trying
to remove dependencies on node state so these initialization steps can
be broken down.
doc(core, main)
de45277
fix(core) don't assume Repo won't be nil
19c2c65
fix(core) improve documentation and describe behavior of function
15a6237
doc(core) add TODO
c1ff214
refactor(core) switch style to type assertions
a025fc9 
@jbenet cool with this?
rename coreio to coreunix
b0596cd
refactor(core) extract const
797aad9
@btc
Copy link
Contributor Author

btc commented Jan 18, 2015

this is tested pretty thoroughly, but it's changes are cross-cutting so I still worry about regressions. Going to merge now. Let me know if you experience any strange issues around core.IpfsNode Close().

@whyrusleeping @jbenet

btc pushed a commit that referenced this pull request Jan 18, 2015
Merge pull request #578 from jbenet/feat/core+repo
c70e717 
feat(core) replace config.Config with repo.Repo
@btc btc merged commit c70e717 into master Jan 18, 2015
@btc btc deleted the feat/core+repo branch January 18, 2015 23:08
@btc btc removed the status/in-progress In progress label Jan 18, 2015
@btc btc removed their assignment Mar 30, 2015
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Oct 23, 2021
@Stebalien
Merge pull request ipfs#578 from alanshaw/chore/linting-fixes
969e03e 
chore: linting fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
α
Development

Successfully merging this pull request may close these issues.

introduce "repo" package to manage IPFS_DIR concerns
2 participants
@btc @jbenet