Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.4.19 #6026

Merged
merged 3 commits into from
Mar 1, 2019
Merged

Release 0.4.19 #6026

merged 3 commits into from
Mar 1, 2019

Conversation

Stebalien
Copy link
Member

I don't anticipate any other changes. I'll merge this and cut the release
tomorrow if nothing happens between now and then.

@Stebalien Stebalien requested a review from Kubuxu as a code owner February 26, 2019 20:50
@ghost ghost assigned Stebalien Feb 26, 2019
@ghost ghost added the status/in-progress In progress label Feb 26, 2019
@magik6k
Copy link
Member

magik6k commented Feb 26, 2019

#6019 will introduce API breaking change, but I don't think it's worth blocking release on that. (And there is still this comment https://github.com/ipfs/interface-go-ipfs-core/blob/master/unixfs.go#L39)

@Stebalien Stebalien mentioned this pull request Feb 27, 2019
Closed
@Stebalien
Copy link
Member Author

Meh, I consider the CoreAPI to be unstable/internal for now.

@Kubuxu
Copy link
Member

Kubuxu commented Feb 27, 2019

What about other blockers #5867 (comment)

@Stebalien
Copy link
Member Author

@Kubuxu I'll rebase this once we've merged fixes for those (and possibly cut another RC).

Stebalien added 3 commits March 1, 2019 12:32
@Stebalien
CHANGELOG: add instructions for enabling truncate on a badger datastore
b6b9261 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
release 0.4.19
83d3f76 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
bump version to 0.4.20-dev
0cbb3d4 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien force-pushed the feat/release-0.4.19 branch from 0ea8c62 to 0cbb3d4 Compare March 1, 2019 20:34
djdv
djdv approved these changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@djdv djdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the issues I encountered with the RCs have been resolved and I haven't encountered any new ones.

@Stebalien Stebalien merged commit 71d7cf7 into master Mar 1, 2019
@ghost ghost removed the status/in-progress In progress label Mar 1, 2019
@Stebalien Stebalien deleted the feat/release-0.4.19 branch March 1, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djdv djdv djdv approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stebalien @magik6k @Kubuxu @djdv