refactor(net:message) add NetMessage interface #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Design Goal: reduce coupling * NB: Slices hold references to an underlying array, and if you assign one slice to another, both refer to the same array. If a function takes a slice argument, changes it makes to the elements of the slice will be visible to the caller, analogous to passing a pointer to the underlying array.
|
LGTM! |
btc
pushed a commit
that referenced
this pull request
Sep 13, 2014
refactor(net:message) add NetMessage interface
ribasushi
pushed a commit
that referenced
this pull request
Jul 4, 2021
Deprecate EventLogging and Warning* functions
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
gx publish 2.5.3
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
feat: add graphsync option
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
feat: add graphsync option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one slice to another, both refer to the same array. If a function
takes a slice argument, changes it makes to the elements of the slice
will be visible to the caller, analogous to passing a pointer to the
underlying array.