-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releases: switch to alpha, beta, rcN flow #6496
Conversation
This way: 1. The quality of every release stage is clear. 2. We can invite users to run RCs in production because they're _actually_ RCs. And a bunch of other nits.
@@ -0,0 +1,27 @@ | |||
# Go-IPFS Changelog Template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broke this out as it doesn't really belong in the release issue (IMO) but in the release notes themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure though, was this supposed to go in the issue itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. See ipfs/js-ipfs#2192
- [ ] Network Testing: | ||
- [ ] test lab things | ||
- [ ] Infrastructure Testing: | ||
- [ ] Deploy new version to a subset of Bootstrappers | ||
- [ ] Deploy new version to a subset of Gateways | ||
- [ ] Deploy new version to a subset of Preload nodes | ||
- [ ] Collect metrics every day. Work with the Infrastructure team to learn of any hiccup | ||
- [ ] IPFS HTTP Client Libraries Testing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are now completely automated.
Addresses #6482 (comment) (well, #6482 (comment)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the progression of stages a lot. Minor wording change.
|
||
When Release Stage 1, there is a features freeze for the release branch. | ||
When releasing the first alpha, there is a features freeze for the release branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When releasing the first alpha, there is a features freeze for the release branch. | |
When releasing the alpha, there is a features freeze for the release branch. |
- **Release Stage 2 - Invite _early testers_ to try it out** - Reach out to our _early testers_ (i.e. projects that have volunteered to support `go-ipfs` by using their own test infrastructure and tell us the results) | ||
- **Release Stage 3 - Announce to the broader community** - Communicate to the community that a new Release Candidate is ready and that everyone is welcome to test it with us | ||
- **Release Stage 4 - Complete the Release** - Finalize the release, start the next release. | ||
### Alpha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've very mixed feelings of overloading terms that are already super overloaded.
IPFS is Alpha software. Having a Alpha release of Alpha software will be confusing, plus moving to a Beta and Final stage of Alpha software will be misunderstood and people will just start talking about IPFS as non Alpha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. This also makes it hard to restart the process because we can't really go from rc1 back to alpha. I'm opening a new PR where stages and versions are independent.
|
||
### Changelog | ||
|
||
< changelog generated by bin/mkreleaselog > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should come before the Contributors section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried about burying the contributors. This is what an itemized changelog looks like for go-ipfs: https://github.com/ipfs/go-ipfs/blob/master/CHANGELOG.md#changelog
Closing in favor of #6500. |
This way:
And a bunch of other nits commented inline.