cmd: ipfs handle GUI environment on Windows

[djdv]

Resolves: #6633

Hacky but maybe acceptable.

If we're not launched from a terminal, we launch the daemon by default.
If we're inside of a terminal, we print help.

https://youtu.be/diam0dQaBdw
(for some reason my cursor didn't get recorded)

[djdv]

I'm thinking this should also pass --init along with daemon though.
Otherwise it's still going to launch a ghost window on a fresh install.

Opinions?

[Stebalien]

Nice! I'm slightly concerned that we'll log something on init and break this but I can't think of a good way to fix that.

I'm thinking this should also pass --init along with daemon though. Otherwise it's still going to launch a ghost window on a fresh install. Opinions?

👍. This makes sense. We've been discussing making this the default anyways.

[djdv]

Force pushed over this.
Same as before, but now with --init appended as well.

[djdv]

We should probably explicitly block on #1897
It seems like Golang's signal library doesn't send us anything on a WM_CLOSE and instead just kills us immediately if the user sends alt-f4 or clicks the window X.
:^(

I'll have to see if there's a way to get notified of these events from the OS. Otherwise we won't gracefully shutdown (unless the user sends ctrl-c/interrupt).

[djdv]

It seems like Golang's signal library doesn't send us anything on a WM_CLOSE and instead just kills us immediately if the user sends alt-f4 or clicks the window X.

This is no longer the case in Go 1.14.
It's worth noting that we receive the shutdown signal but this is not a guarantee we'll shutdown gracefully. The OS will still decide to stop the process if shutdown takes longer than its grace period.
(Typically 5 seconds).

[Stebalien]

❤️