Auto-comment on submitted PRs #7248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Give a few tips on linking relevant discussions, self reviews, additional reviews and code contribution guidelines * Be explicit about the next steps and what to expect.
|
@hsanjuan is it possible to give this some sort of predefined |
You would be able to filter out the botname (even block it on github so you don't even see these). |
Stebalien
reviewed
Apr 29, 2020
Co-Authored-By: Steven Allen <steven@stebalien.com>
Co-Authored-By: Steven Allen <steven@stebalien.com>
I know. I've done another pass trying to be more concise. Can you check? |
Stebalien
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reviews and code contribution guidelines
I would like to trial this. A potential problem I see is that this will comment on every PR (including ours) and might be annoying for the people that sends most PRs. We can switch to commenting on only first-time PRs but then we miss the chance to remind people that only occasionally contribute (and ourselves about the process to follow).