Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(godoc) add doc.go in project root #73

Merged
merged 1 commit into from
Sep 15, 2014
Merged

docs(godoc) add doc.go in project root #73

merged 1 commit into from
Sep 15, 2014

Conversation

btc
Copy link
Contributor

@btc btc commented Sep 14, 2014

improves godoc representation

@btc btc added status/in-progress In progress codereview and removed status/in-progress In progress labels Sep 14, 2014
jbenet added a commit that referenced this pull request Sep 15, 2014
docs(godoc) add doc.go in project root
@jbenet jbenet merged commit 8281b4a into master Sep 15, 2014
@jbenet jbenet removed the codereview label Sep 15, 2014
@jbenet jbenet deleted the package-docs.go branch September 15, 2014 08:36
ribasushi pushed a commit that referenced this pull request Jul 4, 2021
Fixes #73 by normalizing paths to UNC on windows. This is _slightly_ less hacky
than registering a new schema.

The underlying issue was twofold:

1. When specifying a windows file URL as `file://c:/foo/bar`, go barfs because
`:` can't be in a domain name.
2. When specifying a windows file URL as `file:///c:/foo/bar`, we'd end up
trying to open `/c:/foo/bar` which is actually `CURRENT_DRIVE:/c:/foo/bar`.
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Feb 25, 2022
feat: add private routing config field
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Feb 25, 2022
…-routing

feat: add private routing config field
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Mar 4, 2022
…-routing

feat: add private routing config field
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Mar 4, 2022
…-routing

feat: add private routing config field
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants