feat(gateway): Content-Disposition improvements #7677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements 'attachment' mode triggered then ?filename parameter is accompanied with &download=true When Content-Disposition: attachment is detected by a modern browser it will skip rendering and immediately open the "save as" dialog, making this useful feature for using IPFS gateway as target of "Download" links on various websites. Parameter name was suggested in: #4177 (comment)
This adds ASCII-only filename for clients that do not implement RFC 5987 Closes #7648
achingbrain
approved these changes
Sep 17, 2020
aschmahmann
approved these changes
Oct 2, 2020
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
…attachment feat(gateway): Content-Disposition improvements This commit was moved from ipfs/kubo@9b1171d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the way gateway supports
Content-Disposition, an HTTP header used by browsers as a name hint when saving a file:Content-Disposition: attachmentwhen?filenameis accompanied by&download=trueThis is a fully backward-compatible change, sharness tests included.
cc (#4177 – @Voker57 @crackcomm @radfish) ipfs/in-web-browsers#132 @andrew @Gozala @autonome