p2p/net/conn: respect context on dialing #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were half-way with this. there's no way for net.Dialers to respect contexts, so we have to let the dial finish in the background.
jbenet
force-pushed
the
dial-respect-ctx
branch
from
615f244
to
5171d3d
Compare
jbenet
added a commit
that referenced
this pull request
Feb 11, 2015
p2p/net/conn: respect context on dialing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were half-way with this. there's no way for net.Dialers to respect
contexts, so we have to let the dial finish in the background.