Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node API #8046

Merged
merged 3 commits into from
Apr 24, 2021
Merged

Node API #8046

merged 3 commits into from
Apr 24, 2021

Conversation

hannahhoward
Copy link
Contributor

Goals

Provide a direct interface to IPLD prime based tools for reading and writing DAGs
implement ipfs/interface-go-ipfs-core#68

Implementation

Implement the node API by just combining go-fetcher.FetcherConfig + go-dagwriter.DagWritingService

For Discussion

I went ahead and augmented the fetcher with unixfs functionality -- should we do this?

@willscott
Copy link
Contributor

@aschmahmann notes that for interfaces added to the interfaces-go-ipfs-core, we'd like for the go-ipfs-http-client to also be able to implement that interface. e.g.: https://github.com/ipfs/go-ipfs-http-client/blob/3af36210f80fb86aae50da582b494ceddd64c3de/dag.go

We need to think about whether there's a sane way to plum the exposed interface over the http interface

implement a node interface that provides direct access to go-ipld-prime tools

License: MIT
Signed-off-by: hannahhoward <hannah@hannahhoward.net>
License: MIT
Signed-off-by: hannahhoward <hannah@hannahhoward.net>
Update to latest fetcher/dag-writer and fix node api

License: MIT
Signed-off-by: hannahhoward <hannah@hannahhoward.net>
@hannahhoward hannahhoward merged commit 98b792a into feat/ipld-in-ipfs Apr 24, 2021
@hacdias hacdias deleted the feat/node-api branch May 9, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants