Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow key export in online mode #8113

Merged
merged 4 commits into from
May 12, 2021
Merged

feat: allow key export in online mode #8113

merged 4 commits into from
May 12, 2021

Commits on May 7, 2021

  1. feat: allow key export in online mode 

    Export does not require repo lock and it is safe to do even when ipfs
daemon is running. This enables apps like Brave browser to do
import/export without stopping/starting daemon.

Ref. brave/brave-browser#15422
    @lidel
    lidel committed May 7, 2021
    Configuration menu
    Copy the full SHA
    a158036 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. test: confirm /api/v0/key/export is HTTP 404 

    This ensures key export endpoint is never exposed over HTTP API
    @lidel
    lidel committed May 11, 2021
    Configuration menu
    Copy the full SHA
    48bc573 View commit details
    Browse the repository at this point in the history

  2. fix: check repo version before key export 

    #8113 (comment)
    @lidel
    lidel committed May 11, 2021
    Configuration menu
    Copy the full SHA
    6b63de8 View commit details
    Browse the repository at this point in the history

  3. refactor: key export requires exact repo ver

    @lidel
    lidel committed May 11, 2021
    Configuration menu
    Copy the full SHA
    1d77f9d View commit details
    Browse the repository at this point in the history