Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: print error on bootstrap failure #8166

Merged
merged 2 commits into from
Jun 14, 2021
Merged

feat: print error on bootstrap failure #8166

merged 2 commits into from
Jun 14, 2021

Conversation

lidel
Copy link
Member

@lidel lidel commented May 31, 2021

This PR aims to improve UX when bootstrap fails.

It will print ERROR to log if daemon running in online mode has no peers after one minute since start:

$ ipfs daemon
...
Daemon is ready
2021-05-31T15:28:34.403+0200	ERROR	cmd/ipfs	ipfs/daemon.go:527	failed to bootstrap (no peers found): consider updating Bootstrap or Peering section of your config

@lidel
feat: print error on bootstrap failure
039e12a 
This will print ERROR to log if daemon running in online mode has no
peers after one minute since start.
@lidel lidel requested review from Stebalien and aschmahmann May 31, 2021 13:38
@godcong
Copy link
Contributor

godcong commented Jun 1, 2021

Why is the error not a warning? In a private network, there may not be bootstrap at the beginning

@aschmahmann aschmahmann requested a review from gammazero June 7, 2021 15:24
gammazero
gammazero requested changes Jun 7, 2021
View reviewed changes
cmd/ipfs/daemon.go Show resolved Hide resolved
@lidel lidel requested a review from gammazero June 7, 2021 16:16
@aschmahmann aschmahmann merged commit f05f84a into master Jun 14, 2021
aschmahmann pushed a commit that referenced this pull request Jun 22, 2021
@lidel @aschmahmann
refactor: warning when bootstrap disabled by user
a70be54 
#8166 (comment)
(cherry picked from commit 904cc73)
aschmahmann pushed a commit that referenced this pull request Jun 22, 2021
@lidel @aschmahmann
refactor: warning when bootstrap disabled by user
7bba2a6 
#8166 (comment)
(cherry picked from commit 904cc73)
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
Closed
62 tasks
@hacdias hacdias deleted the feat/bootstrap-error branch May 9, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gammazero gammazero gammazero approved these changes

@Stebalien Stebalien Awaiting requested review from Stebalien

@aschmahmann aschmahmann Awaiting requested review from aschmahmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lidel @godcong @gammazero @aschmahmann