-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multibase in pubsub http rpc #8183
fix: multibase in pubsub http rpc #8183
Commits on Oct 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a6ffb28 - Browse repository at this point
Copy the full SHA a6ffb28View commit details -
Configuration menu - View commit details
-
Copy full SHA for fce6413 - Browse repository at this point
Copy the full SHA fce6413View commit details -
Update core/commands/pubsub.go
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Configuration menu - View commit details
-
Copy full SHA for a663e78 - Browse repository at this point
Copy the full SHA a663e78View commit details -
refactor(pubsub): base64url for all URL args
This makes it easier to reason about. Also added better helptext to each command explaining how the binary data is encoded on the wire, and how to process it in userland.
Configuration menu - View commit details
-
Copy full SHA for d075dd6 - Browse repository at this point
Copy the full SHA d075dd6View commit details -
refactor: remove ndpayload and lenpayload
Those output formats are undocumented and seem to be only used in tests. This change removes their implementation and replaces it with error message to use JSON instead. I also refactored tests to test the --enc=json response format instead of imaginary one, making tests more useful as they also act as regression tests for HTTP RPC.
Configuration menu - View commit details
-
Copy full SHA for 82a0a95 - Browse repository at this point
Copy the full SHA 82a0a95View commit details -
Testing against compatible version from ipfs/go-ipfs-api#255
Configuration menu - View commit details
-
Copy full SHA for d4f80fb - Browse repository at this point
Copy the full SHA d4f80fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7afd125 - Browse repository at this point
Copy the full SHA 7afd125View commit details -
refactor(pubsub): unify peerids
This ensures `ipfs pubsub sub` returns the same peerids in the `From` field as `ipfs pubsub peers`. libp2p already uses base encoding, no need to double wrap or use custom multibase.
Configuration menu - View commit details
-
Copy full SHA for 31b3541 - Browse repository at this point
Copy the full SHA 31b3541View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bd282d - Browse repository at this point
Copy the full SHA 5bd282dView commit details -
refactor(pubsub): make pub command read from a file
We want to send payload in the body as multipart so users can use existing tools like curl for publishing arbitrary bytes to a topic. StringArg was created for "one message per line" use case, and if data has `\n` or `\r\n` byte sequences, it will cause payload to be split. It is not possible to undo this, because mentioned sequences are lost, so we are not able to tell if it was `\n` or `\r\n` We already avoid this problem in `block put` and `dht put` by reading payload via FileArg which does not mangle binary data and send it as-is. It feel like `pubsub pub` should be using it in the first place anyway, so this commit replaces StringArg with FileArg. This also closes ipfs#8454 and makes rpc in go-ipfs easier to code against.
Configuration menu - View commit details
-
Copy full SHA for e426088 - Browse repository at this point
Copy the full SHA e426088View commit details -
test(pubsub): publishing with line breaks
Making sure we don't see regressions in the future. Ref. ipfs#7939
Configuration menu - View commit details
-
Copy full SHA for 84e0eb1 - Browse repository at this point
Copy the full SHA 84e0eb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 153697d - Browse repository at this point
Copy the full SHA 153697dView commit details
Commits on Nov 23, 2021
-
test: t0322-pubsub-http-rpc.sh
- Adds HTTP RPC regression test that ensures topic is encoded as URL-safe multibase. - Moves pubsub tests to live in unique range ./t032x
Configuration menu - View commit details
-
Copy full SHA for 8c77377 - Browse repository at this point
Copy the full SHA 8c77377View commit details
Commits on Nov 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e3118b6 - Browse repository at this point
Copy the full SHA e3118b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9955071 - Browse repository at this point
Copy the full SHA 9955071View commit details -
fix(ci): js-ipfs with fixed pubsub wire format
uses js-ipfs from ipfs/js-ipfs#3922
Configuration menu - View commit details
-
Copy full SHA for 582eaf1 - Browse repository at this point
Copy the full SHA 582eaf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a8d771 - Browse repository at this point
Copy the full SHA 1a8d771View commit details