Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: circuit v1 migration prompt when Swarm.EnableRelayHop is set #8559

Merged
merged 3 commits into from
Nov 23, 2021

Conversation

marten-seemann
Copy link
Member

This PR doesn't build, as it depends on #8522.
Also depends on ipfs/go-ipfs-config#157.

I didn't want to pile on that PR though, it's already chaotic enough..

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would clarify how to enable RelayV1 in relayd (its disabled right now) and do the hard stop when EnableRelayHop:true

core/node/groups.go Outdated Show resolved Hide resolved
core/node/groups.go Outdated Show resolved Hide resolved
core/node/groups.go Show resolved Hide resolved
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm.
While not ideal, this provides existing users of v1 with an actionable path to move forward if they need to continue running v1 in their infra.

@lidel lidel marked this pull request as ready for review November 23, 2021 11:38
@lidel lidel changed the title warn when Swarm.EnableRelayHop is set feat: circuit v1 migration prompt when Swarm.EnableRelayHop is set Nov 23, 2021
@guseggert guseggert mentioned this pull request Nov 23, 2021
80 tasks
@lidel lidel changed the base branch from master to update-libp2p November 23, 2021 19:16
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched to go-ipfs-config v0.18.0, squashing this into update-libp2p branch so we have a single PR with libp2p stuff.

@lidel lidel merged commit d510aa3 into update-libp2p Nov 23, 2021
@lidel lidel deleted the warn-on-enable-relay-hop branch November 23, 2021 19:21
lidel added a commit that referenced this pull request Nov 23, 2021
…8559)

* exit when Swarm.EnableRelayHop is set
* chore: go-ipfs-config v0.18.0

Co-authored-by: Marcin Rataj <lidel@lidel.org>
aschmahmann added a commit that referenced this pull request Nov 29, 2021
…xts (#8563)

* plumb through go-datastore context changes

* update go-libp2p to v0.16.0
* use LIBP2P_TCP_REUSEPORT instead of IPFS_REUSEPORT
* use relay config
* making deprecation notice match the go-ipfs-config key
* docs(config): circuit relay v2
* docs(config): fix links and headers
* feat(config): Internal.Libp2pForceReachability

This switches to config that supports setting and reading
Internal.Libp2pForceReachability OptionalString flag

* use configuration option for static relays

* chore: go-ipfs-config v0.18.0

https://github.com/ipfs/go-ipfs-config/releases/tag/v0.18.0

* feat: circuit v1 migration prompt when Swarm.EnableRelayHop is set (#8559)
* exit when Swarm.EnableRelayHop is set
* docs: Experimental.ShardingEnabled migration

This ensures existing users of global sharding experiment get notified
that the flag no longer works + that autosharding happens automatically.

For people who NEED to keep the old behavior (eg. have no time to
migrate today) there is a note about restoring it with
`UnixFSShardingSizeThreshold`.

* chore: add dag-jose code to the cid command output

* add support for setting automatic unixfs sharding threshold from the config
* test: have tests use low cutoff for sharding to mimic old behavior
* test: change error message to match the current error
* test: Add automatic sharding/unsharding tests (#8547)
* test: refactored naming in the sharding sharness tests to make more sense

* ci: set interop test executor to convenience image for Go1.16 + Node
* ci: use interop master

Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Gus Eggert <gus@gus.dev>
Co-authored-by: Lucas Molas <schomatis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants