Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): dist.ipfs.io sync preserving binaries #8588

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

lidel
Copy link
Member

@lidel lidel commented Dec 6, 2021

This is a quick fix for #8494

  • tar.gzs got mangled because of reasons known to github and nodejs (had no bandwidth to dig why)
  • this does the correct upload every time by reading file as Buffer and forcing github to interpret payload as an opaque stream of bytes of a known length without anything fancy – makes this as future-proof as possible
  • I confirmed this fix works in https://github.com/libp2p/go-libp2p-relay-daemon/releases/tag/v0.1.0 (reuploaded _linux-amd64.tar.gz was the same as on dist.ipfs.io)

tar.gz got mangled because of reasons known to github,
this does the correct upload every time by forcing github to interpret
payload as an opaque stream of bytes without anything fancy
Copy link
Contributor

@petar petar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aschmahmann aschmahmann merged commit 7026952 into master Dec 6, 2021
@aschmahmann aschmahmann deleted the fix/dist-binary-sync branch December 6, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants