Dependancy updates to Go.mod packages #8822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bhaskar <hey@bhaskar.email>
|
@bhaskarvilles the tests are failing you need to |
I got no errors in local branch, but the upgrades was clear and no conflicts with base branch, why it happens with CI ? |
|
Because your local tests dont check for go mod tidy. |
|
@bhaskarvilles: thanks for the PR. We usually do this as part of our release process. We will get that formulated in #8576 . I'm closing this as a result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have checked the latest versions from package repositories and changed to best upgrades availabe.
Signed-off-by: Bhaskar hey@bhaskar.email