Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/commands): do not cache config #8824

Merged
merged 3 commits into from
Mar 27, 2022
Merged

fix(core/commands): do not cache config #8824

merged 3 commits into from
Mar 27, 2022

Conversation

schomatis
Copy link
Contributor

Closes #7481.

From the issue description:

The config attached to the command context is not the same config returned by repo.Config(). The commands context should just ask the repo for the config.

@schomatis schomatis self-assigned this Mar 25, 2022
@schomatis schomatis enabled auto-merge (squash) March 25, 2022 20:23
@schomatis schomatis merged commit d928870 into master Mar 27, 2022
guseggert
guseggert approved these changes Mar 27, 2022
View reviewed changes
Copy link
Contributor

@guseggert guseggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love to see diffs with lots of red

@schomatis schomatis deleted the schomatis/fix/do-not-cache-config branch March 27, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guseggert guseggert guseggert approved these changes

@Stebalien Stebalien Awaiting requested review from Stebalien

@aschmahmann aschmahmann Awaiting requested review from aschmahmann

Assignees

@schomatis schomatis

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config inconsistent at runtime
2 participants
@schomatis @guseggert