-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update soft block limit to 2MiB #8968
base: master
Are you sure you want to change the base?
Conversation
e518f3a
to
53d219d
Compare
may 26 2022 discussion:
|
Other possible solution if this drag on too much, revert 04e7e95 in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm moving this to 0.15: this needs end-to-end regression tests so we are not surprised when something changes deep in one of libp2p deps. We want tests for two cases:
- confirm two nodes exchange 2MiB block
- confirm two nodes are unable to exchange 2MiB+1 byte block
What's the priority of this? What is motivating this work? |
|
This still needs tests described in #8968 (review) |
I know, I didn't took time to wrote them yet. |
53d219d
to
3dd2098
Compare
I didnt do this because we don't really have consensus on this: ipfs/specs#331 (comment) |
This is needed because the 1MiB limit is the chunker limit, however the actual blocks can be wrapped in protobuf which adds a small ~10 byte overhead.
3dd2098
to
efc758a
Compare
This is needed because the 1MiB limit is the chunker limit, however the
actual blocks can be wrapped in protobuf which adds a small ~10 byte
overhead.