Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cmds): dag import: use ipld legacy decode #9219

Merged
merged 1 commit into from
Oct 13, 2022
Merged

chore(cmds): dag import: use ipld legacy decode #9219

merged 1 commit into from
Oct 13, 2022
+13 −2

Conversation

schomatis
Copy link
Contributor

Closes #9198.

@schomatis schomatis requested a review from aschmahmann August 23, 2022 15:16
@schomatis schomatis self-assigned this Aug 23, 2022
@schomatis
Copy link
Contributor Author

Tried to add an analog for export (ipfs dag export --output-codec) but couldn't follow all the ipld prime selection logic. Can try a bit more if this is valuable.

@schomatis schomatis force-pushed the schomatis/chore/dag-import/use-ipld-legacy-decode branch from 1b6dbe8 to 1d968b7 Compare August 24, 2022 18:52
@schomatis schomatis enabled auto-merge August 24, 2022 19:00
@hacdias hacdias force-pushed the schomatis/chore/dag-import/use-ipld-legacy-decode branch from 1d968b7 to bd6c7fd Compare October 13, 2022 14:41
@guseggert guseggert requested review from hacdias and removed request for aschmahmann October 13, 2022 14:41
@hacdias hacdias force-pushed the schomatis/chore/dag-import/use-ipld-legacy-decode branch from bd6c7fd to e48626f Compare October 13, 2022 14:45
@schomatis schomatis merged commit 4b33079 into master Oct 13, 2022
@hacdias hacdias deleted the schomatis/chore/dag-import/use-ipld-legacy-decode branch October 13, 2022 14:55
@lidel lidel mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacdias hacdias hacdias approved these changes

Assignees

@schomatis schomatis

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle any supported IPLD codec for CAR imports
2 participants
@schomatis @hacdias