Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Delegated routing with custom configuration. #9274

Merged
merged 19 commits into from
Sep 22, 2022
Merged

feat: Delegated routing with custom configuration. #9274

merged 19 commits into from
Sep 22, 2022

Conversation

ajnavarro
Copy link
Member

@ajnavarro ajnavarro commented Sep 13, 2022 •
edited
Loading

New multi-router configuration system based on https://hackmd.io/G1KRDEX5T3qyfoBMkIrBew#Methods

  • Added a new routing type: "custom"
  • Added specific struct types for different Routers (instead of map[string]interface{})
  • Added Duration config type, to make easier time string parsing
  • Added config documentation.
  • Use the latest go-delegated-routing library version with GET support.
  • Added changelog notes for this feature.

It:

@ajnavarro ajnavarro requested a review from guseggert September 13, 2022 13:35
ajnavarro
ajnavarro commented Sep 13, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
This was referenced Sep 13, 2022
Closed
Closed
@ajnavarro ajnavarro modified the milestone: Best Effort Track Sep 13, 2022
@ajnavarro ajnavarro self-assigned this Sep 13, 2022
@ajnavarro ajnavarro mentioned this pull request Sep 15, 2022
Closed
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch from e408da1 to c0d9101 Compare September 16, 2022 10:56
@ajnavarro ajnavarro marked this pull request as ready for review September 16, 2022 20:49
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch from a1ea310 to 7573b72 Compare September 16, 2022 21:42
@ischasny ischasny mentioned this pull request Sep 18, 2022
Closed
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch 3 times, most recently from 5113650 to 0c32e28 Compare September 19, 2022 09:59
@galargh galargh mentioned this pull request Sep 19, 2022
Closed
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch 2 times, most recently from 6491bc5 to d59a23c Compare September 21, 2022 12:13
guseggert
guseggert requested changes Sep 21, 2022
View reviewed changes
routing/delegated.go Outdated Show resolved Hide resolved
routing/delegated.go Outdated Show resolved Hide resolved
routing/delegated.go Outdated Show resolved Hide resolved
config/types.go Outdated Show resolved Hide resolved
routing/delegated.go Outdated Show resolved Hide resolved
routing/delegated.go Outdated Show resolved Hide resolved
routing/delegated.go Outdated Show resolved Hide resolved
routing/delegated.go Outdated Show resolved Hide resolved
routing/delegated.go Show resolved Hide resolved
test/sharness/t0701-delegated-routing-reframe.sh Show resolved Hide resolved
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch 2 times, most recently from 79961eb to 98a7acf Compare September 21, 2022 19:11
@ajnavarro ajnavarro requested a review from guseggert September 21, 2022 19:14
@BigLep
Copy link
Contributor

BigLep commented Sep 22, 2022

@ajnavarro : I don't think we should say "closes #9150" since that issue is done when reframe is used in Kubo in production. This PR is an important step but not the end.

@ajnavarro
Copy link
Member Author

@BigLep removed that issue from the list.

@ajnavarro
feat: Delegated routing with custom configuration.
8da6b99
@ajnavarro
Support ProvideMany on Composer Router.
c01a50b 
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro
Update go-delegated-routing library
c9fceec 
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro
Add documentation
9dd9cf9 
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro
Add logs
755af69 
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch from 36a8454 to 6fbe75d Compare September 22, 2022 09:29
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch 2 times, most recently from 1f890c9 to 5307ed1 Compare September 22, 2022 11:30
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch from 5307ed1 to a067db5 Compare September 22, 2022 11:37
@ajnavarro ajnavarro merged commit d1b9e41 into master Sep 22, 2022
@ajnavarro ajnavarro deleted the feature/delegated-routing-v2 branch September 22, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guseggert guseggert guseggert approved these changes

Assignees

@ajnavarro ajnavarro

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
3 participants
@ajnavarro @BigLep @guseggert