-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: --reset flag on swarm limit command #9310
Conversation
6221488
to
b22d3f7
Compare
f4150c2
to
92bcb8e
Compare
I'm still trying to ramp back up on this code b/c it is quite complex, but there are some things not working end-to-end, for example:
|
Yeah, I didn't fully understand the logic with default values here, so I was resetting to zero values as a default (that is how it works with unset values if you set a specific limit, all other values will be zero values). |
This flag allows to the user to reset limits to default values. Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Co-authored-by: Gus Eggert <gus@gus.dev>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
b7c3059
to
03b564e
Compare
This flag allows the user to reset limits to default values.
It closes #8918
Signed-off-by: Antonio Navarro Perez antnavper@gmail.com