Feat/ls headers #951
Merged
Feat/ls headers #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| Marshalers: cmds.MarshalerMap{ | ||
| cmds.Text: func(res cmds.Response) (io.Reader, error) { | ||
| output := res.Output().(*LsOutput).Objects | ||
|
|
||
| output := res.Output().(*LsOutput) |
There was a problem hiding this comment.
you can get the request object and the options from the response here. Not sure if thats the right way to do it, but its what ive been doing.
There was a problem hiding this comment.
so,
headers, _, err := res.Request().Option("headers").Bool()here
|
@cryptix just fixed it! dont worry :) 👍 thanks for this PR! |
|
i'll squash (to make sure every commit passes) when these tests pass. |
- added tests for 'ipfs ls --headers' - comments from CR (opts) - sharness: fix ls test whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #372, this fixes #893 .