fix: disable provide over HTTP with Routing.Type=auto #9511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
lidel
changed the title
lidel
reviewed
Dec 16, 2022
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
ajnavarro
force-pushed
the
ajnavarro/feat/option-a-disable-provide-on-http-routing
branch
from
be0cf82
to
ca078dd
Compare
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
|
@lidel I already fixed the problem! PTAL when you have time. |
Closed
Adds IPFS_HTTP_ROUTERS and uses it in basic regression test that confirms the default mode (Routing.Type=auto) sends lookups over HTTP for unknown CIDs but no requests are sent with announcements.
lidel
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Thank you @ajnavarro, works as expected.
Quick note:
- Added basic regression test in 858dc78 that confirms we send GETs but no PUTs
- It introduces
IPFS_HTTP_ROUTERSoverride for use in tests (similar toIPFS_NS_MAP), which allows for tests that work reliably, even without WAN (won't be flaky due to cid.contact).
- It introduces
lidel
deleted the
ajnavarro/feat/option-a-disable-provide-on-http-routing
branch
galargh
pushed a commit
that referenced
this pull request
Jan 4, 2023
lidel
pushed a commit
that referenced
this pull request
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying A solution from #9504
Closes #9504 cc #9417