-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix Router config Godoc #9528
Conversation
config/routing.go
Outdated
// Reframe type allows to add other resolvers using the Reframe spec: | ||
// https://github.com/ipfs/specs/tree/main/reframe | ||
// In the future we will support "dht" and other Types here. | ||
// Currenly supported Types are "http", "dht", "parallel", "sequential". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the source of truth here? Is it https://github.com/ipfs/kubo/blob/master/docs/config.md#routingrouters-type or is a constant in code? I think it would be ideal to link to the source of truth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the source of truth is RouterType
, the type of the variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave it another try to be more specific and avoid the same problem with outdated godoc in the future.
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
268a785
to
986d0db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (good idea to refer relevant IPIP)
Co-authored-by: Marcin Rataj <lidel@lidel.org>
@ajnavarro I belive you should squash since you have a merge commit, I'm not 100% sure tho. |
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Signed-off-by: Antonio Navarro Perez antnavper@gmail.com