Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix Router config Godoc #9528

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Conversation

ajnavarro
Copy link
Member

Signed-off-by: Antonio Navarro Perez antnavper@gmail.com

// Reframe type allows to add other resolvers using the Reframe spec:
// https://github.com/ipfs/specs/tree/main/reframe
// In the future we will support "dht" and other Types here.
// Currenly supported Types are "http", "dht", "parallel", "sequential".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the source of truth here? Is it https://github.com/ipfs/kubo/blob/master/docs/config.md#routingrouters-type or is a constant in code? I think it would be ideal to link to the source of truth.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the source of truth is RouterType , the type of the variable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it another try to be more specific and avoid the same problem with outdated godoc in the future.

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro ajnavarro force-pushed the ajnavarro/docs/fix-router-godoc branch from 268a785 to 986d0db Compare January 4, 2023 16:36
@ajnavarro ajnavarro requested review from lidel and BigLep January 4, 2023 16:46
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (good idea to refer relevant IPIP)

config/routing.go Outdated Show resolved Hide resolved
@lidel lidel changed the title Docs: Fix Router config Godoc. docs: fix Router config Godoc Jan 4, 2023
@ajnavarro ajnavarro enabled auto-merge (rebase) January 5, 2023 10:17
@Jorropo
Copy link
Contributor

Jorropo commented Jan 5, 2023

@ajnavarro I belive you should squash since you have a merge commit, I'm not 100% sure tho.

@ajnavarro ajnavarro enabled auto-merge (squash) January 5, 2023 12:23
@ajnavarro ajnavarro merged commit ca0396e into master Jan 5, 2023
@ajnavarro ajnavarro deleted the ajnavarro/docs/fix-router-godoc branch January 5, 2023 12:38
galargh pushed a commit that referenced this pull request Jan 23, 2023
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants