fix: clarity: no user supplied rcmgr limits of 0 #9563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of this commit is to make clear that we don't support user-supplied limits of 0 currently. Apply (https://github.com/libp2p/go-libp2p/blob/master/p2p/host/resource-manager/limit.go#L102 ) overrides any 0 value. With the current code, a zero-limit in userSuppliedOverrideLimitConfig will be overridden by the computed default limits. I want to be able to do: ``` defaultComputedLimitConfig.Apply(userSuppliedOverrideLimitConfig) ``` but that won't override any of the computed defaults. I'd like to see this fixed, but this at least make clear the situation.
ajnavarro
reviewed
Jan 19, 2023
ajnavarro
approved these changes
Jan 19, 2023
lidel
reviewed
Jan 19, 2023
lidel
changed the title
Closed
Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com>
|
I think we're good to merge now @lidel , but will let you check. |
|
@BigLep You need to format the code to make Go checks pass. |
|
Doh - thanks @ajnavarro . I guess that's what I get for making Go code changes in the Github UI. It looks like I'm good now... |
…th-zero-values-not-supported
lidel
approved these changes
Jan 22, 2023
There was a problem hiding this comment.
I took this PR for a spin and agree we are better with it in 0.18. Merging. 👍
Some thoughts:
- Without this PR we would have very bad time migrating and cleaning up user configs in 0.19 when go-libp2p has explicit
0support. Good call @BigLep - UX of doing anything with ResourceMgr via CLI + config is pure torture, but since we have autoscaling I hope not many people will have to touch it too much.
- I've found two bugs and filled ipfs swarm limit all --reset does not remove user overrides from Swarm.ResourceMgr.Limits #9576 and ipfs swarm limit all: returns empty "" Service and Protocol name #9577 but none of them should block 0.18, fine to fix them later.
lidel
deleted the
fix/clarity-resource-mgr-user-overrides-with-zero-values-not-supported
branch
galargh
pushed a commit
that referenced
this pull request
Jan 23, 2023
Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com> Co-authored-by: Marcin Rataj <lidel@lidel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this commit is to make clear that we don't support user-supplied limits of 0 currently. Apply (https://github.com/libp2p/go-libp2p/blob/master/p2p/host/resource-manager/limit.go#L102 ) overrides any 0 value. With the current code, a zero-limit in userSuppliedOverrideLimitConfig will be overridden by the computed default limits.
I want to be able to do:
but that won't override any of the computed defaults.
I'd like to see this fixed, but this at least make clear the situation.