Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update go-libp2p to v0.25.1 #9647

Merged
merged 2 commits into from
Feb 14, 2023
Merged

chore: update go-libp2p to v0.25.1 #9647

merged 2 commits into from
Feb 14, 2023

Conversation

marten-seemann
Copy link
Member

No description provided.

@Jorropo Jorropo mentioned this pull request Feb 14, 2023
Merged
@Jorropo Jorropo force-pushed the update-libp2p-v025 branch 3 times, most recently from cc50a70 to 6a45235 Compare February 14, 2023 09:51
@mvdan mvdan mentioned this pull request Feb 14, 2023
Merged
@Jorropo Jorropo force-pushed the update-libp2p-v025 branch 6 times, most recently from 93f65cb to 08490a4 Compare February 14, 2023 13:19
hacdias
hacdias approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with this code, but the changes look fine to me. As long as tests are passing, I think it's OK to merge.

@Jorropo
Copy link
Contributor

Jorropo commented Feb 14, 2023 •
edited
Loading

Depends on libp2p/go-libp2p#2094 used an ugly work around.

@Jorropo Jorropo changed the title chore: update go-libp2p to v0.25.1 chore: update go-libp2p to v0.25.2 Feb 14, 2023
@Jorropo Jorropo mentioned this pull request Feb 14, 2023
Closed
@Jorropo Jorropo enabled auto-merge (rebase) February 14, 2023 20:51
@Jorropo Jorropo disabled auto-merge February 14, 2023 20:55
@Jorropo Jorropo enabled auto-merge (rebase) February 14, 2023 20:55
@Jorropo Jorropo changed the title chore: update go-libp2p to v0.25.2 chore: update go-libp2p to v0.25.1 Feb 14, 2023
@Jorropo Jorropo merged commit 0ff4061 into master Feb 14, 2023
@Jorropo Jorropo deleted the update-libp2p-v025 branch February 14, 2023 21:27
@alebcay alebcay mentioned this pull request Feb 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacdias hacdias hacdias approved these changes

@Jorropo Jorropo Awaiting requested review from Jorropo

Assignees

@Jorropo Jorropo

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marten-seemann @Jorropo @hacdias