test: fix "invert" commands in sharness tests #9652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many tests assume that
grep --invert-match "X" FILE
meansBut the command actually means:
Which is wrong in most cases.
test_should_not_contain
instead.grep -v
, it's confusing maintainers.Example:
kubo/test/sharness/t0140-swarm.sh
Lines 95 to 109 in 3bcc89b
Test's Intent:
"/ip4/1.2.3.4/tcp/1234"
to the listNoAnnounce
,But the command
grep -v "/ip4/1.2.3.4/tcp/1234" actual
succeeds even if the file contains/ip4/1.2.3.4/tcp/1234
:Which means that the assertion is a no-op.
suspects matching
ack -l 'grep.*-v'
:Relates to #9651