Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: webui@4.0.1 #9940

Merged
merged 3 commits into from
Jun 14, 2023
Merged

feat: webui@4.0.1 #9940

merged 3 commits into from
Jun 14, 2023

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Jun 12, 2023 •
edited
Loading

@SgtPooki SgtPooki requested a review from lidel as a code owner June 12, 2023 23:27
whizzzkid
whizzzkid approved these changes Jun 12, 2023
View reviewed changes
Copy link

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@SgtPooki SgtPooki mentioned this pull request Jun 12, 2023
Closed
@hacdias hacdias requested a review from a team as a code owner June 13, 2023 10:36
hacdias
hacdias requested changes Jun 13, 2023
View reviewed changes
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interop tests with the Web UI are failing. I upgraded the Node.js version to 18.x which fixed part of the issue. The tests are still not running due to some timeout. Does anyone have an idea?

(Tests are also failing in all commits since IPLD Explorer changes were merged yesterday, so I guess whatever was changed there is related to this.)

@hacdias hacdias force-pushed the webui-4.0.0 branch 2 times, most recently from 8885dba to 9ea19ee Compare June 13, 2023 12:23
@hacdias hacdias mentioned this pull request Jun 13, 2023
Merged
@SgtPooki
Copy link
Member Author

interop/ipfs-webui is failing due to playwright timeout when booting up webserver.

Run npm run test:e2e

> ipfs-webui@4.0.0 test:e2e
> cross-env REACT_APP_ENV=test npx playwright test -c ./test/e2e

Error: Timed out waiting 60000ms from config.webServer.

e2e tests have been starting up and passing fine locally and in ipfs-webui repo.. but i'm looking

@SgtPooki
Copy link
Member Author

ok, repro'd locally. weird.

@SgtPooki SgtPooki mentioned this pull request Jun 13, 2023
Merged
@SgtPooki
Copy link
Member Author

should be fixed by ipfs/ipfs-webui#2122

@SgtPooki SgtPooki changed the title feat: webui@4.0.0 feat: webui@4.0.1 Jun 14, 2023
@SgtPooki SgtPooki requested a review from hacdias June 14, 2023 08:03
hacdias
hacdias approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this and for fixing the E2E tests issues!

@hacdias hacdias merged commit c93e267 into master Jun 14, 2023
@hacdias hacdias deleted the webui-4.0.0 branch June 14, 2023 08:12
hacdias pushed a commit that referenced this pull request Jun 15, 2023
@SgtPooki @hacdias
feat: webui@4.0.1 (#9940)
93fa661
hacdias pushed a commit that referenced this pull request Jun 15, 2023
@SgtPooki @hacdias
feat: webui@4.0.1 (#9940)
c495914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacdias hacdias hacdias approved these changes

@whizzzkid whizzzkid whizzzkid approved these changes

@lidel lidel Awaiting requested review from lidel lidel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SgtPooki @whizzzkid @hacdias