Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: docker with go 1.22, kuboreleaser with go 1.21 #34

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Mar 4, 2024

No description provided.

@hacdias
Copy link
Member Author

hacdias commented Mar 4, 2024

@galargh any ideas why the go checks are failing?

@galargh
Copy link
Contributor

galargh commented Mar 4, 2024

Looks like go mod edit -json cannot infer that we're after go 1.22. Weird that other commands don't have this problem. We'll be working on UCI release later this week which means we'll have to deal with it.

@galargh
Copy link
Contributor

galargh commented Mar 4, 2024

@hacdias Our regular, scheduled Unified GitHub Workflows update doesn't face this problem - #35.

I suspect it's because of the toolchain directive the update with go mod tidy -go=... did.
Edit: Looks like it's specific to 1.22 and toolchain doesn't have to be explicitly specified after all - #36
Edit 2: I think I know what's going on. In Go checks, we use the Go version installed on the hosted runner to extract the version from go.mod. The version installed is 1.21.x. When the go.mod has a newer version than the installed, Go tries to download newer toolchain. Since specific toolchain is not specified in the go.mod file, it tries to just download 1.22 toolchain. But that toolchain doesn't exist. All in all, it'll make sense to install latest stable Go in Go check workflow the same way we do it for Go test.

Note that in the other PR, we updated to 1.21 in go.mod file. That's the regular cadence the Unified GitHub Workflows have been following. Is there any reason we want to go skip that?

@hacdias
Copy link
Member Author

hacdias commented Mar 5, 2024

@galargh Kubo has been updated to Go 1.22 - so at least the Docker container needs to be updated to Go 1.22 to avoid issues when running the changelog maker. But indeed Kuboreleaser can stay on 1.21

@hacdias hacdias changed the title chore: go 1.22 chore: docker with go 1.22, kuboreleaser with go 1.21 Mar 5, 2024
@hacdias hacdias requested a review from galargh March 5, 2024 08:26
@hacdias hacdias merged commit 564ad71 into main Mar 7, 2024
9 checks passed
@hacdias hacdias deleted the go-1.22 branch March 7, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants