Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

Common Sharness test repo for all IPFS implemetations #265

Open
chriscool opened this issue Oct 10, 2017 · 2 comments
Open

Common Sharness test repo for all IPFS implemetations #265

chriscool opened this issue Oct 10, 2017 · 2 comments

Comments

@chriscool
Copy link

@diasdavid suggested creating a common Sharness repo that would host the Sharness test scripts for all the IPFS implementations.

Current Sharness tests require a number of go programs like go-sleep, go-timeout, hang-fds, ma-pipe-unidir, go-poll-endpoint (see https://github.com/ipfs/go-ipfs/blob/master/test/sharness/Rules.mk), so go must be available on the Docker image where the Sharness tests are run.

This is a current problem for js-ipfs (see ipfs/js-ipfs#522).

We could have js-ipfs and go-ipfs builds trigger Sharness tests in the common Sharness repo to fix that problem.

But then one problem is that it looks like Travis doesn't have and doesn't plan to add the "dependent build" feature:

travis-ci/travis-ci#249

So we would need another way to trigger Sharness builds when the js-ipfs and go-ipfs repo are updated.

@Kubuxu
Copy link
Member

Kubuxu commented Oct 10, 2017

We could have a docker image with tooling in it (and the suite) and then you would volume mount your implementation with ipfs "binary". We will be also moving away from Travis and expanding our Jenkins so we have a lot more possibility.

@chriscool
Copy link
Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants