Simplify access token spec #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
remove-auth-parameter
branch
from
f29b07f to
e7944c0
Compare
This simplifies authorization logic and removes the surface for leaking token via URL as noted in #37 (comment) It also fixes backlinks in the human-readable docs Closes #37
lidel
force-pushed
the
remove-auth-parameter
branch
from
e7944c0 to
7174f51
Compare
jacobheun
approved these changes
Jul 28, 2020
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies authorization logic and removes the surface for leaking token via URL as noted in #37 (comment)
Pinning Services only need to implement support for the HTTP header.
PREVIEW: https://bafybeib4xyzuzrsk5pl5vvqt6mwlor2w2xj6b6yqj7lgqrlhoafgmgaoey.ipfs.dweb.link/#specUrl=https://raw.githubusercontent.com/ipfs/pinning-services-api-spec/remove-auth-parameter/ipfs-pinning-service.yaml
Closes #37 cc @obo20 @GregTheGreek @priom @jsign @sanderpick @andrewxhill