style: rename object returned with error #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to avoid ambogous `ErrorError` in generated client code. This does not change the JSON format sent between client and server.
lidel
requested review from
andrew,
jessicaschilling,
aschmahmann and
a team
andrew
approved these changes
Sep 22, 2020
|
Linting is failing due to the Error schema no longer existing where previously referenced. |
|
@jacobheun fixed – ok to merge and tag it as v0.1.1 so @andrew and @aschmahmann can re-generate clients with updated object names? |
jacobheun
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
Errorresponse object toFailureThe idea is to avoid ambiguous
ErrorErrorin generated client code.This does not change the JSON format sent between client and server.
cc @aschmahmann @andrew