add net/http compression #61
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ns4plabs
force-pushed
the
http-compression
branch
from
16ab23c
to
a0257ce
Compare
lidel
reviewed
Feb 11, 2024
There was a problem hiding this comment.
This is blocked until we figure out two things:
- problem identified in someguy deployment: Compression enabled without client asking for it via Accept-Encoding ipshipyard/waterworks-community#13
- alternative to
Content-Length, allowing JS apps to lear the size of the uncompressed payload Add Ipfs-DagSize and/or Ipfs-DataSize to gateway responses specs#461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Accept-Encoding header and http compression.
We received a user report regarding changed behaviour of HEAD requests initiated by web browsers. Chrome and Firefox add
Accept-Encoding: gzip, deflate, brheader. In such cases the response does not includeContent-Length- the compressed body size is unknown.A potential solution, which will still allow us to enable compression, is to exclude HEAD requests from the compression handler. Unfortunately at the time this would mean forking
github.com/CAFxX/httpcompression