Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: service-worker-gateway inbrowser.link MVP #31

Closed
30 of 45 tasks
lidel opened this issue Feb 23, 2024 · 11 comments
Closed
30 of 45 tasks

Epic: service-worker-gateway inbrowser.link MVP #31

lidel opened this issue Feb 23, 2024 · 11 comments
Assignees

Comments

@lidel
Copy link
Member

lidel commented Feb 23, 2024

For general use

Minimal feature set

Optimizations

Security and Compliance

UX / Configuration

For inbrowser.link


Until we get automated testing in place, here's a list of CIDs of websites for testing the Service Worker Gateway

Site CID IPNS subdomain
Wikipedia on IPFS bafybeiaysi4s6lnjev27ln5icwm6tueaw2vdykrtjkwiphwekaywqhcjze n/a
Uniswap Interface bafybeifaiclxh6pc3bdtrrkpbvvqqxq6hz5r6htdzxaga4fikfpu2u56qi n/a
CID tool bafybeiae366charqmeewxags5b2jxtkhfmqyyagvqhrr5l7l7xfpp5ikpa cid-ipfs-tech.ipns
IPFS Docs bafybeiedlhslivmuj2iinnpd24ulx3fyd7cjenddbkeoxbf3snjiz3npda docs-ipfs-tech.ipns
@2color 2color pinned this issue Feb 27, 2024
@2color
Copy link
Member

2color commented Mar 1, 2024

I think we should consider how we name this and call it in the docs and materials we will create before we make a splash. I propose we call it "Service Worker IPFS Gateway" or just "Service Worker Gateway" since the fact that it uses Helia is an implementation detail for most users. Moreover, it should be pretty clear that it's powered by Helia since it's the most actively maintained JS IPFS implementation.

I figured it's a good time be bring it up since we're going to be using the inbrowser.link domain for it (which already doesn't have Helia in it).

@lidel
Copy link
Member Author

lidel commented Mar 1, 2024

@2color agree, we can mention Helia on the landing page (#58) but this project should be branded as "Service Worker [IPFS] Gateway" or ipfs-swgw.

We already have to move to ipfs/ org, renaming repo could happen at the same time.
Let's discuss details in #80

@lidel lidel mentioned this issue Mar 1, 2024
8 tasks
@SgtPooki SgtPooki self-assigned this Mar 4, 2024
@2color
Copy link
Member

2color commented Mar 7, 2024

I added a list of CID of sites for manual testing to the issue body. Feel free to add any additional ones.

@SgtPooki
Copy link
Member

SgtPooki commented Mar 8, 2024

NOTE: subdomains don't automatically refresh the service worker.. so we need some clever logic for checking for service worker assets, and then redirecting to /#/ipfs-sw-config again.

see #96 for some changes that make this more likely to happen

@SgtPooki
Copy link
Member

SgtPooki commented Mar 8, 2024

Question: should we default to an ipfs favicon when favicon.ico doesn't exist...?

@lidel
Copy link
Member Author

lidel commented Mar 11, 2024

We should not modify immutable data. If the DAG that user tries to load does not have favicon, we should not add it.

@lidel lidel changed the title Epic: helia-service-worker-gateway Productionisation Epic: service-worker-gateway Productionisation Mar 26, 2024
@2color
Copy link
Member

2color commented Mar 26, 2024

Add the following examples to the list and make sure are working well enough before sharing:

  • Video
  • ENS link
  • IPNS name

@SgtPooki SgtPooki moved this to 🏃‍♀️ In Progress in IPFS Shipyard Team Apr 4, 2024
@SgtPooki SgtPooki added this to the Initial release milestone Apr 8, 2024
@lidel lidel changed the title Epic: service-worker-gateway Productionisation Epic: service-worker-gateway inbrowser.link MVP Dec 5, 2024
@lidel
Copy link
Member Author

lidel commented Dec 5, 2024

I think this is greatly outdated, most of things got resolved, and remaining ones changed priority. We did not maintain list in this issue since March.

Let's close this to reduce noise – if we need new milestone/epic we will fill new issue

@lidel lidel closed this as completed Dec 5, 2024
@lidel
Copy link
Member Author

lidel commented Dec 5, 2024

@SgtPooki thanks for flagging, for issues that exist in other repos:

we should have dedicated tickets here that can be closed once a dependency update with fix is applied. Mind creating them? (using same title + link to upstream bug is enough).

@lidel lidel unpinned this issue Dec 5, 2024
@SgtPooki
Copy link
Member

SgtPooki commented Dec 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏃‍♀️ In Progress
Development

No branches or pull requests

3 participants