Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hacks like changeCssFontPath #33

Closed
lidel opened this issue Feb 23, 2024 · 3 comments
Closed

Remove hacks like changeCssFontPath #33

lidel opened this issue Feb 23, 2024 · 3 comments
Assignees

Comments

@lidel
Copy link
Member

lidel commented Feb 23, 2024

Not urgent, just filling issue so we dont forget to clean this up

My understanding is that the hack in changeCssFontPath was introduced as a way of demoing how websites can load without having to set up proper origin isolation just for the iframe-based demo.

As part of productizing, we should remove hacks like this: only subdomain-based isolation is supported for web hosting of arbitrary sites and dapps.

The fact that some things do not work on path gateways is "a feature, not a bug",
and if anything, we should warn users who use path gateway for website hosting, as noted in #30.

@lidel
Copy link
Member Author

lidel commented Feb 28, 2024

@SgtPooki isdo you remember if isReferrerPreviouslyIntercepted similar type of fixup?

@SgtPooki
Copy link
Member

I think it is. I tested removing it locally and seemed unnecessary

@SgtPooki SgtPooki self-assigned this Feb 28, 2024
@SgtPooki
Copy link
Member

SgtPooki commented Mar 8, 2024

I believe this is done with #96

@SgtPooki SgtPooki closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants