Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch to cloudflare pages #247

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

lidel
Copy link
Member

@lidel lidel commented May 8, 2024

Closes #244

  • removes CI orchestration related to dnslink and loading via gateway infra
  • removes coupling between deployments and merges to main or tagging a release
    • we now have separate staging (inbrowser.dev) and production (inbrowser.link) branches which are how things are deployed to inbrowser domains via cloudflare pages

@lidel
Copy link
Member Author

lidel commented May 8, 2024

I am merging this to switch CI to follow #244, we can refine text later.

cc @SgtPooki @2color for visibility

Once this lands:

  • push to staging deploys to inbrowser.dev
  • push to production deploys to inbrowser.link
  • they no longer depend on dnslink and ipfs resolution
  • release-please only makes release, does not do any automated deployment (did more harm than good)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4304333) to head (fd01da6).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #247   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           35        81   +46     
  Branches         5         9    +4     
=========================================
+ Hits            35        81   +46     
Flag Coverage Δ
node 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lidel lidel merged commit 289aca7 into main May 8, 2024
16 checks passed
@lidel lidel deleted the refactor/cloudflare-pages branch May 8, 2024 22:28
@lidel lidel mentioned this pull request May 9, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch static asset hosting to Cloudflare Pages
2 participants