fix: remove hashes from build outputs and simplify build #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to simplify the build by removing hashes from filenames of build outputs.
How important is it to have the hashes in the script outputs?
Since we have the cache headers set to
Cache-control: public, max-age=0, must-revalidateset from, we might want to consider removing the additional logic (which seems a bit flaky) for removing the hash for the service worker, and injecting the scripts into the index.html.However, since we also cache assets in the service worker, this makes things more complicated, because we have no expiry mechanism for sw assets in the service worker.