This repository has been archived by the owner on Feb 8, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create 2018-11-21--gui-and-in-web-browsers-weekly.md #771
Create 2018-11-21--gui-and-in-web-browsers-weekly.md #771
Changes from 1 commit
0c40683
0bf7cfe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thaank you ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it use the Service Worker Gateway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could. Right now it's using ipfs-redux-bundle that chooses the best available connection and fires up a
js-ipfs
instance as a fallback.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woa! I didn't know about that!
Can someone do a video tutorial pleaaase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ipfs-redux-bundle is React-specific lib we use internally for R&D in WebUI/Companion/Desktop, API is not stable yet :)
In the following weeks we will extract the fallback logic into a separate, framework-agnostic lib and make tutorials for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just gave share.ipfs.io a spin. Was intrigued by
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, this is kind of the same as https://filenation.io. What is different in this app that justifies creating and maintaining another codebase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fsdiogo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I follow the question in the image. This is not supposed to mimic a gateway, the visible url and # is for the app internal routing.
It's similar in the way that is an app to share files, yes.
js-ipfs
as fallback if needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To compliment Diogo's points, there is a relevant background discussion in ipfs/ipfs-gui#34 (Design: Share files via IPFS).
IIRC historical reasoning for ipfs-share-files was along these lines:
Third party solutions come and go and are not robust enough. Some require a writable gateway, use centralized backend or don't use js-ipfs fallback at all etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be cool to have channels just like the exchange files example has
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is something that is being discussed (ipfs/ipfs-gui#52, ipfs/ipfs-gui#36) but probably will fall under the Web UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also ipfs/ipfs-gui#57 ("hackpad for file sharing" ) which is exactly about taking the "exchange files example", refining the UX and integrating it with ipfs-webui (directly or via ipfs-share-files).
The wow factor of doing this right could be massive. This will happen for sure, but we want to get MVP with basic sharing out of the door, and iterate from there.