Skip to content

Need a strict boundary check for resolved? #2

Open
@spacewander

Description

@spacewander

In https://github.com/ipipdotnet/ipdb-c/blob/master/ipdb.c#L142:

if (resolved >= reader->file_size) {
        return ErrDatabaseError;
    }

int size = (reader->data[resolved] << 8) | reader->data[resolved + 2];

Maybe we need to replace resolved >= reader->file_size with resolved >= reader->data_size, because the boundary of reader->data is data_size not file_size.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions