-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update ipld and deps #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I can't figure out why Travis is always failing. If I checkout master it fails there too. |
You can debug the e2e tests by running I'm seeing a js-ipfs init error when running via puppeteer, which is weird, I don't see this when running locally. Failed to initialise js-ipfs Error: No resolver found for codec "undefined"
at IPLDResolver.put (index.js:221)
at DAGNode.create (object.js:135)
at multihashing (create.js:53)
at Multihashing.Multihashing.digest (index.js:33)
at index.js:15
at run (setImmediate.js:40)
at runIfPresent (setImmediate.js:69)
at onGlobalMessage (setImmediate.js:109) |
The test passes on |
Oooh, i am able to recreate this locally if I delete all the indexedDB instances for the localhost:3000 |
So the good news is that the smoke test caught an issue, we need to update js-ipfs on this PR! |
- Update to latest IPFS to fix IPLD api compat issues - Update to create-react-app v2 to fix > ES2015 compilation issues from ipfs-mfs using spread operator - Remove webpack config hack - Bundle stats now generated by CRA - Removed multipled unused deps License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
- remove lint step from travis. switching to prettier - pin bable-core version while ipld-explorer-components depends on older one. see: facebook/create-react-app#5259 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
This makes ipld-explorer work with the new api changes from IPLD.
Also switched from
source-map-explorer
towebpack-bundle-analyzer
.Ref: ipfs/ipfs-webui#948