Move index generation functionality to root v2 package #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move index generation functionality to root, because they read/write CAR files. This leaves the `index` package to only contain the index implementation itself. Move `index.Attach` to root while at it following the same logic. Add TODOs to the implementation of Attach to make it more robust. As is it _could_ result in corrupt v2 files if offset includes padding since v2 header is not updated in this function. Add tests to generate index and move existing tests to correspond to the go file containing generation functionality.
mvdan
approved these changes
Jul 13, 2021
Earlier reviews suggested moving more io utilities to internal: #145 Either works I have no preference. The rule I follow is if it's used in more than one place then move to internal otherwise leave in package that utilises it. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move index generation functionality to root, because they read/write CAR
files. This leaves the
indexpackage to only contain the indeximplementation itself.
Move
index.Attachto root while at it following the same logic. AddTODOs to the implementation of Attach to make it more robust. As is it
could result in corrupt v2 files if offset includes padding since v2
header is not updated in this function.
Add tests to generate index and move existing tests to correspond to the
go file containing generation functionality.