Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate CLI to separate module #231

Merged
merged 8 commits into from
Sep 12, 2021
Merged

Separate CLI to separate module #231

merged 8 commits into from
Sep 12, 2021

Conversation

willscott
Copy link
Member

  • move to go get github.com/ipld/go-car/cmd/car
  • remove use of v2/internal packages

@@ -49,7 +49,7 @@ func FilterCar(c *cli.Context) error {
}
fmt.Printf("filtering to %d cids\n", len(cidMap))

rd, err := icarv1.NewCarReader(r.DataReader())
rd, err := carv1.NewCarReader(r.DataReader())
Copy link
Member

@masih masih Sep 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR: I think instead of opening a carv2.Reader then opening a carv1.Reader from the data payload, you can directly use carv2.BlockReader which gives you an iterator over CAR blocks may it be a v1 or v2 along with access to roots etc.

@willscott willscott merged commit d252cb9 into master Sep 12, 2021
@willscott willscott deleted the climod branch September 12, 2021 13:07
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants